-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace GuzzleHttp with PSR-18 HTTP Clients #1032
Conversation
5339d7d
to
d043769
Compare
what needs to happen to move forward with this? :) |
i tested this with my application and can confirm that everything is working as expected so far for me 👍 |
I'll review this while I'm on holiday, coming up in a couple of weeks, and will merge it then. It might require a new major version, which I'm happy to tag for this. We have an interesting history with these kinds of requests, and I bet @shadowhand would agree with me that we are way overdue to accept this. 😁 I'm going to tag a bunch of issues and PRs from over the years here, just to connect things together:
|
Don't worry about the test failures on PHP 7.1 and earlier. If I tag this for a new major version, I'll be dropping support for everything before PHP 8.1. |
I'll fix the unit tests errors running on 8.1+ |
cfda3e4
to
2de9e08
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #1032 +/- ##
======================================
Coverage ? 99.03%
Complexity ? 195
======================================
Files ? 19
Lines ? 517
Branches ? 0
======================================
Hits ? 512
Misses ? 5
Partials ? 0
|
5ca87bd
to
7f85a84
Compare
@flavioheleno FYI, I've created a |
This pull request replaces the Guzzle HTTP Client with PSR 17 and 18 interfaces. Closes #1019.
Changes to Dependencies:
psr/http-client
,psr/http-factory
, andpsr/http-message
were added to therequire
section.guzzlehttp/guzzle
package was moved to therequire-dev
section.Changes to the AbstractProvider Class:
HttpClientInterface
was replaced withClientInterface
from the PSR-18 standard.RequestFactory
was replaced withRequestFactoryInterface
andStreamFactoryInterface
from the PSR-17 standard.Removal of the RequestFactory Class:
RequestFactory
class was removed as it's no longer needed with the introduction of the PSR-17 standard interfaces.